This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] [x86_32] Don't use SSE4_2 instructions on Intel Silvermont Micro Architecture.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Liubov Dmitrieva <liubov dot dmitrieva at gmail dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 03 Jul 2013 12:40:01 -0400
- Subject: Re: [PATCH] [x86_32] Don't use SSE4_2 instructions on Intel Silvermont Micro Architecture.
- References: <CAHjhQ93YUtMz14Aj7JfhJ7Tq++eC+23cA6yubh1KPRpKTvvkaw at mail dot gmail dot com> <51D0967A dot 7050102 at redhat dot com> <CAHjhQ92mTi8OmY7RBC3=sCaX=-xbgGH82pCBz4fCQkBLJcNqOA at mail dot gmail dot com> <CAMe9rOr8o7OnB0T0tG50J7oXmJJF_XOiUDLK6Gsc1tMu-NOFrQ at mail dot gmail dot com> <CAHjhQ90Hrj78WYJ_sQ2Eu7mzf63Wbnuihcv88KBMdxJo5q1Yxg at mail dot gmail dot com> <CAMe9rOojGtDZcb6Phk3a1sp+B3XhQwRJo9ZjovC==1OG2_8k=g at mail dot gmail dot com> <CAMe9rOro+9nJ2cXHfa4xa9TPZRfn_zt19waHc_80GLRWaC4K+g at mail dot gmail dot com> <CAMe9rOrKxrf07KY5xiHhj4YLYvz_RLhENvcUQLE3eZZTu-yJ5A at mail dot gmail dot com> <CAHjhQ927=iGWof4Zm=KOHkVua+7YXe_p57gGmjUu1yj101SZhg at mail dot gmail dot com>
On 07/02/2013 04:13 PM, Liubov Dmitrieva wrote:
>> Can you regenerate the patch?
>
> I did. I also removed memcmp and wmemcmp because we need better
> accuracy benchmarks to be sure about the boost there.
> For str**cmp it looks reasonable to install even measured the
> benchmarks we have in glibc. I attached my results again.
>
> 2013-07-03 Liubov Dmitrieva <liubov.dmitrieva@intel.com>
>
> * sysdeps/i386/i686/multiarch/strcmp.S: Skip SSE4_2
> version if bit_Slow_SSE4_2 is set.
> * sysdeps/i386/i686/multiarch/strncase.S: Likewise.
> * sysdeps/i386/i686/multiarch/strcasecmp.S: Likewise.
OK for 2.19 once it opens.
Cheers,
Carlos.