This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Cleanup #if 0


On Mon, 1 Jul 2013, Ondrej Bilka wrote:

> As this caused problems it would be good idea to globaly remove code 
> surrounded by
> #if 0
> It is easy to automate, question is how many parts can be used and what 
> are bitrotten.

Typically any cleanup of such code needs to replace it by a comment 
explaining the reason the code does not do whatever the #if 0 code did, if 
someone might still think that was a reasonable thing to do (and in some 
such cases, the #if 0 code may make sense to keep to accompany and clarify 
the comment).  That is, automation isn't useful beyond locating where #if 
0 code is present in the source tree; every case needs individual manual 
consideration involving understanding why the #if 0 code and conditionals 
are there in the first place.

(Other #if cleanups may still be useful.  For example, cleaning up 
conditionals on __GNUC__ or on the GCC version being sufficiently recent 
when 4.4 is recent enough so the conditional never does anything now - but 
such cleanups can't be done in installed headers, or in filed shared by 
gnulib, so you stll need to examine each case individually to see if 
either of those issues applies.)

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]