This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 06/14] Extend the test suite for TSX and add some new tests to test elision
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Andi Kleen <andi at firstfloor dot org>
- Cc: libc-alpha at sourceware dot org, Andi Kleen <ak at linux dot jf dot intel dot com>
- Date: Fri, 28 Jun 2013 12:33:06 -0400
- Subject: Re: [PATCH 06/14] Extend the test suite for TSX and add some new tests to test elision
- References: <1372398717-16530-1-git-send-email-andi at firstfloor dot org> <1372398717-16530-7-git-send-email-andi at firstfloor dot org> <51CD41F3 dot 2090002 at redhat dot com> <20130628144826 dot GT6123 at two dot firstfloor dot org>
On 06/28/2013 10:48 AM, Andi Kleen wrote:
>>
>> This patch depends on pthread_mutexattr_setelision_np from patch #11.
>
> The new interfaces are ifdefed, so it'll build either way.
>
> The test cases have too much churn for me to maintain separate versions,
> sorry.
>
> Besides the test coverage is very poor without the interfaces, so I
> need it for my testing. If removing the interfaces really
> is a firm requirement I'll just remove the tests instead.
I'm confused, if you build with elision turned on then all the default
mutexes are elided, so why do you need to call the new interface to
turn on elision?
If the existing testsuite runs cleanly with just the base elision patches
then we don't need this new test until we add the new interfaces.
Does the testsuite run cleanly without patch #6?
Cheers,
Carlos.