This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fwd: [PATCH] tdestroy() should allow passing 'NULL' for 'freefct' callback


On Wed, Jun 26, 2013 at 05:37:48PM +0530, Siddhesh Poyarekar wrote:
> On 26 June 2013 17:27, Carlos O'Donell <carlos@redhat.com> wrote:
> > Versioning is an interesting point I hadn't considered. In the past I'd
> > say we haven't always done this kind of bumping of the symbol version
> > to ensure considerate error messages. Though I agree with you, bumping
> > the symbol version is the right thing to do here.
> 
> Why do we need a new symbol version for this?  The new behaviour is
> backward compatible, so the only thing it adds is the ability to pass
> a NULL callback to tdestroy, which would result in a segfault earlier.
>  I doubt if any application does something as silly as passing a NULL
> callback to catch the crash in a SIGSEGV handler to do something
> special.

Any program using the new feature of passing NULL would crash with old
glibc versions. A new symbol version forces it to instead report an
error that a newer glibc is required to run the program.

Rich


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]