This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fwd: [PATCH] tdestroy() should allow passing 'NULL' for 'freefct' callback
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>, OndÅej BÃlka <neleai at seznam dot cz>
- Cc: Ivo Raisr <ivosh at ivosh dot net>, libc-alpha at sourceware dot org
- Date: Wed, 26 Jun 2013 07:57:29 -0400
- Subject: Re: Fwd: [PATCH] tdestroy() should allow passing 'NULL' for 'freefct' callback
- References: <CANXv6=sw64PRodqTgArqUHQLTcQd8eEE_==6QHVHgLn52jh=1Q at mail dot gmail dot com> <20130611081615 dot GA6224 at domone dot kolej dot mff dot cuni dot cz> <CANXv6=vaJwfOKGgNWU55j-xdB5zqhp5_-3tdjS287+UR1r-nDA at mail dot gmail dot com> <CANXv6=sKC3wsF5ZN9So9Pq=BAfcwvveNZHaSvWEZL5KceH+goQ at mail dot gmail dot com> <20130625213231 dot E552A2C08A at topped-with-meat dot com>
On 06/25/2013 05:32 PM, Roland McGrath wrote:
> This is a user-visible change, so needs a BZ. Probably this should use a
> new symbol version. The compat routine need not behave any differently.
> But when someone builds a new program that might rely on the new behavior,
> they should get a symbol version dependency that ensures that attempting to
> run that program against an older library will give a coherent
> binary-compatibility error rather than just crashing in tdestroy.
Roland,
Thanks for the review.
It has a user-visible BZ. It's BZ #15009, as written into the ChangeLog?
Versioning is an interesting point I hadn't considered. In the past I'd
say we haven't always done this kind of bumping of the symbol version
to ensure considerate error messages. Though I agree with you, bumping
the symbol version is the right thing to do here.
I should really keep my eye out for more of these kinds of issues. It's
my fault that I missed this.
Ondrej,
Could you help with adding the appropriate symbol versioning to the patch?
Cheers,
Carlos.