This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Tuesday 25 June 2013 09:00:55 Tulio Magno Quites Machado Filho wrote: > Mike Frysinger <vapier@gentoo.org> writes: > > On Monday 24 June 2013 14:05:25 Carlos O'Donell wrote: > >> On 06/22/2013 02:22 PM, Mike Frysinger wrote: > >> > so i think we're in agreement that these two may go in as-is. > >> > Roland has > >> > mentioned that he plans to write a patch to move libc-mmap.h > >> > to the linux > >> > subdir (which no one is contending is a lot of work, just > >> > whether it's > >> > the right thing to do). what happens after that point is up > >> > in the air, > >> > but regardless, it doesn't impact merging of these two. > >> > > >> > do i have that right ? > >> > >> Yes, that is my understanding also. > > > > ok, i've pushed it. and slipped in this NEWS update: > Mike, > > This commit break the build on powerpc. > > /home/tcbot/bot-slave/glibc/build/glibc32_power4/locale/locarchive.o: > In function `prepare_address_space': > /home/tcbot/bot-slave/glibc/src/locale/programs/locarchive.c:92: > undefined reference to `PTR_ALIGN_UP' > /home/tcbot/bot-slave/glibc/src/locale/programs/locarchive.c:92: > undefined reference to `PTR_ALIGN_UP' > /home/tcbot/bot-slave/glibc/src/locale/programs/locarchive.c:92: > undefined reference to `PTR_ALIGN_UP' > /home/tcbot/bot-slave/glibc/build/glibc32_power4/locale/locarchive.o: > In function `file_data_available_p': > /home/tcbot/bot-slave/glibc/src/locale/programs/locarchive.c:288: > undefined reference to `ALIGN_DOWN' > /home/tcbot/bot-slave/glibc/build/glibc32_power4/locale/locarchive.o: > In function `prepare_address_space': > /home/tcbot/bot-slave/glibc/src/locale/programs/locarchive.c:92: > undefined reference to `PTR_ALIGN_UP' > collect2: error: ld returned 1 exit status > > Can you take a look at this, please? i thought libc-internal.h was an implicit include. guess only libc-symbols.h is that way though. Richard has fixed this: commit 1d17fa5f8e3d5fb84d9b944d5fe3712cde83db48 Author: Richard Henderson <rth@twiddle.net> Date: Tue Jun 25 09:27:01 2013 -0700 Fix missing libc-internal.h include. * locale/programs/locarchive.c: Include <libc-internal.h> -mike
Attachment:
signature.asc
Description: This is a digitally signed message part.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |