This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Smaller fix of crash in pthread_exit()
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Vladimir Nikulichev <v dot nikulichev at gmail dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 24 Jun 2013 14:01:54 -0400
- Subject: Re: [PATCH] Smaller fix of crash in pthread_exit()
- References: <CAKt5dD2GcZ7dUrLJ0dQOdgFkXAHO8bJKCjtdeXzxN+Xd9QerQg at mail dot gmail dot com>
On 06/23/2013 10:54 AM, Vladimir Nikulichev wrote:
> Bug 12310: http://sourceware.org/bugzilla/show_bug.cgi?id=12310
>
> diff --git nptl/ChangeLog nptl/ChangeLog
> index 0e3b018..03a7d5d 100644
> --- nptl/ChangeLog
> +++ nptl/ChangeLog
> @@ -1,3 +1,7 @@
> +2013-06-23 Vladimir Nikulichev <v.nikulichev@gmail.com>
> +
> + * pthread_exit.c: Add reference to pthread_create()
> +
> 2013-06-15 Siddhesh Poyarekar <siddhesh@redhat.com>
>
> * Versions (libpthread): Add GLIBC_2.18.
> diff --git nptl/pthread_exit.c nptl/pthread_exit.c
> index 3718081..639dd28 100644
> --- nptl/pthread_exit.c
> +++ nptl/pthread_exit.c
> @@ -20,6 +20,9 @@
> #include "pthreadP.h"
>
>
> +PTHREAD_STATIC_FN_REQUIRE(pthread_create);
> +
> +
> void
> __pthread_exit (value)
> void *value;
>
The *REQUIRE should be at the end of the file with
a comment explaining why it's required for __pthread_exit.
Please repost v2 of the patch with those changes.
Please review in detail:
http://sourceware.org/glibc/wiki/Contribution%20checklist
Cheers,
Carlos.