This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix soft-fp shadowing between __FP_FRAC_ADD_3 and _FP_MUL_MEAT_2_wide_3mul (bug 15667)
- From: Andreas Jaeger <aj at suse dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Sat, 22 Jun 2013 20:48:36 +0200
- Subject: Re: Fix soft-fp shadowing between __FP_FRAC_ADD_3 and _FP_MUL_MEAT_2_wide_3mul (bug 15667)
- References: <Pine dot LNX dot 4 dot 64 dot 1306221208430 dot 10964 at digraph dot polyomino dot org dot uk>
On 06/22/2013 02:10 PM, Joseph S. Myers wrote:
This patch fixes bug 15667, soft-fp variables _c1 and _c2 in
__FP_FRAC_ADD_3 shadowing those in _FP_MUL_MEAT_2_wide_3mul.
I renamed the variables to include the full macro name. Probably this
should be done for all variables defined internally by any soft-fp
macro (maybe using abbreviated versions of the macro names if the full
names are too long and make the code too cumbersome); this patch
simply addresses the particular case where shadowing actually occurs
and shows up as test failures with the soft-fp fma patch I'll send
separately after some further testing.
Tested on MIPS64 in conjunction with that fma patch.
This is fine, thanks,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126