Re: [PATCH rsa/stdint_noheaders] Cleanup: Add #include <stdint.h> for uint[32|64]_t usage (except installed headers)

[Thomas Schwinge <thomas at codesourcery dot com>]

Hi!

On Thu, 20 Jun 2013 19:10:31 -0400, Carlos O'Donell <carlos@redhat.com> wrote:
> On 06/20/2013 05:24 PM, Thomas Schwinge wrote:
> > Well, as you can see from my ÂI'm seeing snippet above, the build
> > process already happily does recreate the generated file (when its
> > Makefile dependencies tell to do so, I suppose), so -- assuming the
> > generator reliably recreates the file and does not have any special
> > run-time requirements (which might be the argument for keeping configure
> > files checked in) -- there is no point in keeping the generated file
> > checked in other than saving some really minimal amount of build time.
> 
> What about read-only source directories shared amongst multiple builds?

Of course my Âsubsequent action included moving these (that is, modify
their generation Makefile rules) from the source to the build tree.

> > Is this worth a policy change (and subsequent action, for all generated
> > files that are kept checked in; the list of which is still to be
> > determined)?
> 
> I don't think it's worth the policy change. It's just easier for everyone
> to remember to checkin the regenerated files.
> 
> What benefit is there to not checking in the generated file? You'd have
> to go check a long list of such files to remember your's is on the OK
> list and not check it in?

I don't follow you.  If a file is in the source tree, it's checked in; if
it's in the build tree it's not checked in.

Anyway, the issue is moot now that we have established we don't require
Perl for building glibc.


GrÃÃe,
 Thomas

Attachment: pgp5DPRKWg9f8.pgp
Description: PGP signature