This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH rsa/stdint_noheaders] Cleanup: Add #include <stdint.h> for uint[32|64]_t usage (except installed headers)
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: "Ryan S. Arnold" <ryan dot arnold at gmail dot com>, Siddhesh Poyarekar <siddhesh at redhat dot com>, Ryan Arnold <rsa at us dot ibm dot com>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Thu, 20 Jun 2013 19:10:31 -0400
- Subject: Re: [PATCH rsa/stdint_noheaders] Cleanup: Add #include <stdint.h> for uint[32|64]_t usage (except installed headers)
- References: <1367425419 dot 9067 dot 281 dot camel at localhost dot localdomain> <20130516133649 dot GA11396 at domone dot kolej dot mff dot cuni dot cz> <CAAKybw8EP358UABnY2crSGVJxC7R_U-19t95XY0Fw+Cdd9GWwA at mail dot gmail dot com> <CAAKybw-iGGtV9E8tfBmX1Wv_fEq-rrir2pHx8=2gPbNDrKrtOQ at mail dot gmail dot com> <87ppwdo7ho dot fsf at kepler dot schwinge dot homeip dot net> <CAAKybw9dFBbefktz=Ph7afcBZQJ8fH+VwCiWP_pUfKejHFKQ8w at mail dot gmail dot com> <CAAKybw-ose53Km2JKPF96Tr7R0o36F6BpVRr-vpuC1pc0j-pNw at mail dot gmail dot com> <51AE0C0B dot 2080001 at redhat dot com> <877ghopjbf dot fsf at kepler dot schwinge dot homeip dot net>
On 06/20/2013 05:24 PM, Thomas Schwinge wrote:
> Well, as you can see from my ÂI'm seeing snippet above, the build
> process already happily does recreate the generated file (when its
> Makefile dependencies tell to do so, I suppose), so -- assuming the
> generator reliably recreates the file and does not have any special
> run-time requirements (which might be the argument for keeping configure
> files checked in) -- there is no point in keeping the generated file
> checked in other than saving some really minimal amount of build time.
What about read-only source directories shared amongst multiple builds?
> Is this worth a policy change (and subsequent action, for all generated
> files that are kept checked in; the list of which is still to be
> determined)?
I don't think it's worth the policy change. It's just easier for everyone
to remember to checkin the regenerated files.
What benefit is there to not checking in the generated file? You'd have
to go check a long list of such files to remember your's is on the OK
list and not check it in?
Cheers,
Carlos.