This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2 v5] [BZ #10283] localedef: align fixed maps to SHMLBA
- From: David Miller <davem at davemloft dot net>
- To: roland at hack dot frob dot com
- Cc: vapier at gentoo dot org, libc-alpha at sourceware dot org
- Date: Wed, 19 Jun 2013 16:09:45 -0700 (PDT)
- Subject: Re: [PATCH 2/2 v5] [BZ #10283] localedef: align fixed maps to SHMLBA
- References: <1371660248-14405-1-git-send-email-vapier at gentoo dot org> <1371660248-14405-2-git-send-email-vapier at gentoo dot org> <20130619230242 dot 99D1D2C111 at topped-with-meat dot com>
From: Roland McGrath <roland@hack.frob.com>
Date: Wed, 19 Jun 2013 16:02:42 -0700 (PDT)
> You're not going to convince me that SHMLBA counts as "generic".
> The code should be written to make MAP_FIXED_ALIGNMENT optional
> and not do any extra alignment if it's not defined in libc-mmap.h.
> The generic libc-mmap.h should be empty (just comments).
> sysdeps/unix/sysv/linux/libc-mmap.h can use SHMLBA.
>
> It may be worthwhile to define a proper public API for this (probably a GNU
> extension sysconf code makes sense), document that and implement it
> appropriately. The sysdeps/unix/sysv/linux implementation of that could
> just use the existing SHMLBA. Then localedef would be changed to use that
> API. But that's for the future.
Sounds like a lot of pointless churn, when SHMLBA works universally in this
situation.
Your resistence on this issue seems to be unique.