This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[ping2][PATCH][BZ 15362] Fix fwrite() reading beyond end of buffer in error path


Hi,

Could someone please help with a second review of this patch?  This is
a regression in 2.17 and I have proposed it as a blocker for 2.18.
The patch author has a FSF copyright assignment in place and I had
done a first review OK barring a minor formatting issue.

Thanks,
Siddhesh

On 17 April 2013 18:16, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
> On Tue, Apr 16, 2013 at 11:31:14PM -0500, Eric Biggers wrote:
>> I have not been able to run the full test suite because an unrelated test
>> (math/test-ldouble) fails even without my patch.  Also, I did not add a test
>
> Run make check with -k and record which tests fail due to this patch
> (if any).
>
>> -      /* Try to maintain alignment: write a whole number of blocks.
>> -      dont_write is what gets left over. */
>> +      /* Try to maintain alignment: write a whole number of blocks. */
>
> There should be two spaces after the end of the sentence.
>
> The fix looks OK otherwise.  Please confirm that the rest of the
> testsuite is fine after this change.  Please wait for one more
> reviewer to go through this.  Once the final version of the patch is
> ready after review, I can commit it for you.
>
> Thanks,
> Siddhesh



--
http://siddhesh.in


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]