This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix space followed by tab.

From: OndÅej BÃlka <neleai at seznam dot cz>
To: "Joseph S. Myers" <joseph at codesourcery dot com>
Cc: libc-alpha at sourceware dot org
Date: Thu, 6 Jun 2013 12:02:18 +0200
Subject: Re: [PATCH] Fix space followed by tab.
References: <20130605230815 dot GA6738 at domone dot kolej dot mff dot cuni dot cz> <Pine dot LNX dot 4 dot 64 dot 1306052125240 dot 7769 at digraph dot polyomino dot org dot uk> <20130606002427 dot GA18802 at domone dot kolej dot mff dot cuni dot cz>

On Thu, Jun 06, 2013 at 02:24:27AM +0200, OndÅej BÃlka wrote:
> On Wed, Jun 05, 2013 at 09:33:23PM +0000, Joseph S. Myers wrote:
> > By "fix" do you mean specifically fix cases where the <space><tab> 
> > sequence appears that git hooks object to, or other cases as well where 
> > the indentation doesn't follow the preferred rule of a maximal sequence of 
> > tabs followed by 0-7 spaces?  I think the two should be separated, 
> > starting with the cases involving <space><tab>.
> >
Here is patch that fixes space followed by tab, generator attached

This patch ingores files based on following commands:

git checkout intl/plural.c locale/programs/charmap-kw.h 
git locale/programs/locfile-kw.h locale/C-translit.h sysdeps/gnu/errlist.c
git checkout manual/*
git checkout ports/*

Patch is again relatively large(200k) so I put it to:

http://kam.mff.cuni.cz/~ondra/fix_leading_space1.patch

OK to commit?

  * argp/argp-fmtstream.c: Fix space followed by tab.
	* argp/argp-fmtstream.h: Likewise.
	* argp/argp.h: Likewise.
	* argp/argp-help.c: Likewise.
	* argp/argp-parse.c: Likewise.
	* argp/argp-test.c: Likewise.
	* debug/fgetws_u_chk.c: Likewise.
	* elf/dl-load.c: Likewise.
	* elf/dl-minimal.c: Likewise.
	* elf/dl-profile.c: Likewise.
	* elf/rtld.c: Likewise.
	* elf/sln.c: Likewise.
	* hurd/dtable.c: Likewise.
	* hurd/fopenport.c: Likewise.
	* hurd/hurd/fd.h: Likewise.
	* hurd/hurd.h: Likewise.
	* hurd/hurdinit.c: Likewise.
	* hurd/hurdioctl.c: Likewise.
	* hurd/hurd/ioctl.h: Likewise.
	* hurd/hurdlookup.c: Likewise.
	* hurd/hurdmalloc.c: Likewise.
	* hurd/hurdmsg.c: Likewise.
	* hurd/hurdpid.c: Likewise.
	* hurd/hurdsig.c: Likewise.
	* hurd/hurd/signal.h: Likewise.
	* hurd/hurdsock.c: Likewise.
	* hurd/xattr.c: Likewise.
	* include/libc-symbols.h: Likewise.
	* include/shlib-compat.h: Likewise.
	* inet/getnetgrent_r.c: Likewise.
	* inet/ruserpass.c: Likewise.
	* intl/l10nflist.c: Likewise.
	* io/sys/stat.h: Likewise.
	* libio/iofgets_u.c: Likewise.
	* libio/iofgetws_u.c: Likewise.
	* locale/programs/ld-identification.c: Likewise.
	* locale/programs/ld-time.c: Likewise.
	* login/login.c: Likewise.
	* mach/lock-intern.h: Likewise.
	* mach/msg-destroy.c: Likewise.
	* malloc/arena.c: Likewise.
	* malloc/obstack.c: Likewise.
	* malloc/obstack.h: Likewise.
	* misc/error.c: Likewise.
	* nss/getnssent_r.c: Likewise.
	* nss/getXXent_r.c: Likewise.
	* nss/nss_db/db-netgrp.c: Likewise.
	* nss/nss_db/db-XXX.c: Likewise.
	* nss/nss_files/files-alias.c: Likewise.
	* nss/nss_files/files-netgrp.c: Likewise.
	* nss/nss_files/files-XXX.c: Likewise.
	* posix/getopt1.c: Likewise.
	* posix/getopt.c: Likewise.
	* posix/getopt_int.h: Likewise.
	* posix/glob.c: Likewise.
	* posix/regcomp.c: Likewise.
	* posix/regexec.c: Likewise.
	* posix/regex.h: Likewise.
	* posix/regex_internal.c: Likewise.
	* posix/regex_internal.h: Likewise.
	* posix/runtests.c: Likewise.
	* resolv/res_comp.c: Likewise.
	* resolv/res_data.c: Likewise.
	* resolv/res_libc.c: Likewise.
	* soft-fp/op-1.h: Likewise.
	* soft-fp/op-2.h: Likewise.
	* soft-fp/op-4.h: Likewise.
	* soft-fp/op-common.h: Likewise.
	* stdio-common/printf_fp.c: Likewise.
	* stdio-common/printf_fphex.c: Likewise.
	* stdio-common/printf_size.c: Likewise.
	* stdio-common/tst-printf.c: Likewise.
	* stdio-common/vfprintf.c: Likewise.
	* stdlib/fpioconst.c: Likewise.
	* stdlib/random.c: Likewise.
	* stdlib/random_r.c: Likewise.
	* stdlib/strtod_l.c: Likewise.
	* stdlib/strtol_l.c: Likewise.
	* string/argz.h: Likewise.
	* string/envz.c: Likewise.
	* sunrpc/rpc/clnt.h: Likewise.
	* sysdeps/generic/a.out.h: Likewise.
	* sysdeps/generic/dwarf2.h: Likewise.
	* sysdeps/generic/framestate.c: Likewise.
	* sysdeps/generic/ldsodefs.h: Likewise.
	* sysdeps/generic/unwind-dw2.c: Likewise.
	* sysdeps/generic/unwind-dw2-fde.c: Likewise.
	* sysdeps/generic/unwind-dw2-fde.h: Likewise.
	* sysdeps/generic/unwind-pe.h: Likewise.
	* sysdeps/i386/bsd-_setjmp.S: Likewise.
	* sysdeps/i386/bsd-setjmp.S: Likewise.
	* sysdeps/i386/__longjmp.S: Likewise.
	* sysdeps/i386/setjmp.S: Likewise.
	* sysdeps/ieee754/dbl-64/k_rem_pio2.c: Likewise.
	* sysdeps/ieee754/flt-32/e_rem_pio2f.c: Likewise.
	* sysdeps/ieee754/flt-32/k_rem_pio2f.c: Likewise.
	* sysdeps/ieee754/ldbl-128/e_expl.c: Likewise.
	* sysdeps/ieee754/ldbl-128ibm/e_expl.c: Likewise.
	* sysdeps/ieee754/ldbl-128ibm/s_fpclassifyl.c: Likewise.
	* sysdeps/ieee754/ldbl-128ibm/s_nexttoward.c: Likewise.
	* sysdeps/ieee754/ldbl-128ibm/s_scalblnl.c: Likewise.
	* sysdeps/ieee754/ldbl-128ibm/s_scalbnl.c: Likewise.
	* sysdeps/ieee754/ldbl-128/ldbl2mpn.c: Likewise.
	* sysdeps/ieee754/ldbl-128/s_fpclassifyl.c: Likewise.
	* sysdeps/ieee754/ldbl-128/s_llrintl.c: Likewise.
	* sysdeps/ieee754/ldbl-128/s_llroundl.c: Likewise.
	* sysdeps/ieee754/ldbl-128/s_lrintl.c: Likewise.
	* sysdeps/ieee754/ldbl-128/s_lroundl.c: Likewise.
	* sysdeps/ieee754/ldbl-128/s_nexttoward.c: Likewise.
	* sysdeps/ieee754/ldbl-128/s_truncl.c: Likewise.
	* sysdeps/ieee754/ldbl-96/ldbl2mpn.c: Likewise.
	* sysdeps/ieee754/support.c: Likewise.
	* sysdeps/mach/hurd/check_fds.c: Likewise.
	* sysdeps/mach/hurd/dl-sysdep.c: Likewise.
	* sysdeps/mach/hurd/getcwd.c: Likewise.
	* sysdeps/mach/hurd/i386/intr-msg.h: Likewise.
	* sysdeps/mach/hurd/profil.c: Likewise.
	* sysdeps/mach/hurd/setitimer.c: Likewise.
	* sysdeps/posix/euidaccess.c: Likewise.
	* sysdeps/posix/getcwd.c: Likewise.
	* sysdeps/powerpc/powerpc32/dl-machine.c: Likewise.
	* sysdeps/powerpc/powerpc32/lshift.S: Likewise.
	* sysdeps/sparc/sparc32/fpu/s_copysignf.S: Likewise.
	* sysdeps/sparc/sparc32/fpu/s_copysign.S: Likewise.
	* sysdeps/sparc/sparc32/fpu/s_signbitf.S: Likewise.
	* sysdeps/sparc/sparc32/__longjmp.S: Likewise.
	* sysdeps/sparc/sparc64/fpu/s_copysignf.S: Likewise.
	* sysdeps/sparc/sparc64/fpu/s_copysign.S: Likewise.
	* sysdeps/sparc/sparc64/multiarch/memcpy-ultra3.S: Likewise.
	* sysdeps/sparc/sparc64/soft-fp/qp_cmp.c: Likewise.
	* sysdeps/sparc/sparc64/soft-fp/qp_cmpe.c: Likewise.
	* sysdeps/sparc/sparc64/soft-fp/qp_feq.c: Likewise.
	* sysdeps/sparc/sparc64/soft-fp/qp_fge.c: Likewise.
	* sysdeps/sparc/sparc64/soft-fp/qp_fgt.c: Likewise.
	* sysdeps/sparc/sparc64/soft-fp/qp_fle.c: Likewise.
	* sysdeps/sparc/sparc64/soft-fp/qp_flt.c: Likewise.
	* sysdeps/sparc/sparc64/soft-fp/qp_fne.c: Likewise.
	* sysdeps/sparc/sparc64/soft-fp/qp_mul.c: Likewise.
	* sysdeps/sparc/sparc64/soft-fp/qp_qtoi.c: Likewise.
	* sysdeps/sparc/sparc64/soft-fp/qp_qtoui.c: Likewise.
	* sysdeps/sparc/sparc64/soft-fp/qp_qtoux.c: Likewise.
	* sysdeps/sparc/sparc64/soft-fp/qp_qtox.c: Likewise.
	* sysdeps/unix/bsd/telldir.c: Likewise.
	* sysdeps/unix/sysv/linux/lutimes.c: Likewise.
	* sysdeps/unix/sysv/linux/powerpc/powerpc32/clone.S: Likewise.
	* time/mktime.c: Likewise.
	* time/tzfile.c: Likewise.
	* time/tzset.c: Likewise.

libidn/Changelog:


  * libidn/gunicomp.h: Fix space followed by tab.
	* libidn/gunidecomp.h: Likewise.
	* libidn/nfkc.c: Likewise.
	* libidn/rfc3454.c: Likewise.

localedata/Changelog:


  * localedata/tests-mbwc/dat_mblen.c: Fix space followed by tab.
	* localedata/tests-mbwc/dat_towctrans.c: Likewise.

nptl/Changelog:


  * nptl/pthread_create.c: Fix space followed by tab.
	* nptl/sysdeps/unix/sysv/linux/i386/i486/pthread_barrier_wait.S: Likewise.
	* nptl/sysdeps/unix/sysv/linux/powerpc/pt-longjmp.c: Likewise.
	* nptl/sysdeps/unix/sysv/linux/sh/lowlevellock.h: Likewise.
	* nptl/sysdeps/unix/sysv/linux/sh/pthread_barrier_wait.S: Likewise.
	* nptl/sysdeps/unix/sysv/linux/sh/pthread_cond_broadcast.S: Likewise.
	* nptl/sysdeps/unix/sysv/linux/sh/pthread_cond_signal.S: Likewise.
	* nptl/sysdeps/unix/sysv/linux/sh/pthread_cond_timedwait.S: Likewise.
	* nptl/sysdeps/unix/sysv/linux/sh/pthread_cond_wait.S: Likewise.
	* nptl/sysdeps/unix/sysv/linux/sh/pthread_once.S: Likewise.
	* nptl/sysdeps/unix/sysv/linux/sh/pthread_rwlock_rdlock.S: Likewise.
	* nptl/sysdeps/unix/sysv/linux/sh/pthread_rwlock_unlock.S: Likewise.
	* nptl/sysdeps/unix/sysv/linux/sparc/lowlevellock.h: Likewise.
	* nptl/tst-cond22.c: Likewise.
	* nptl/tst-mutexpp10.c: Likewise.
	* nptl/tst-stackguard1.c: Likewise.
	* nptl/tst-umask1.c: Likewise.

Attachment: fix_leading_trailing_space.c
Description: Text document

Follow-Ups:
- [PATCH v2] Fix leading whitespaces.
  - From: OndÅej BÃlka
- Re: [PATCH] Fix space followed by tab.
  - From: Joseph S. Myers

References:
- [PATCH] Fix leading whitespace.
  - From: wizard
- Re: [PATCH] Fix leading whitespace.
  - From: Joseph S. Myers
- Re: [PATCH] Fix leading whitespace.
  - From: OndÅej BÃlka

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]