This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Increase timeout of tst-getaddrinfo4
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 03 Jun 2013 11:49:56 -0400
- Subject: Re: [PATCH] Increase timeout of tst-getaddrinfo4
- References: <20130603091704 dot GJ2145 at spoyarek dot pnq dot redhat dot com>
On 06/03/2013 05:17 AM, Siddhesh Poyarekar wrote:
> Hi,
>
> tst-getaddrinfo4 makes 8 DNS queries, which may take longer than the
> default 3 seconds on a slow network (like my ISP). The following
> patch increases the timeout to 10 seconds. Maybe we ought to move
> this test to xtests, lest it cause spurious failures due to a
> hanging/unresponsive DNS server.
>
> Siddhesh
>
> * posix/tst-getaddrinfo4.c: Increase test timeout.
>
> diff --git a/posix/tst-getaddrinfo4.c b/posix/tst-getaddrinfo4.c
> index 10850cd..464cfb2 100644
> --- a/posix/tst-getaddrinfo4.c
> +++ b/posix/tst-getaddrinfo4.c
> @@ -64,4 +64,5 @@ do_test (void)
> }
>
> #define TEST_FUNCTION do_test ()
> +#define TIMEOUT 10
> #include "../test-skeleton.c"
>
OK.
I'd like to make xtests required for releases :-)
Cheers,
Carlos.