This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [SPATCH] Add space after function call.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: OndÅej BÃlka <neleai at seznam dot cz>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 31 May 2013 19:09:06 +0000
- Subject: Re: [SPATCH] Add space after function call.
- References: <20130530104617 dot GA14219 at domone dot kolej dot mff dot cuni dot cz> <Pine dot LNX dot 4 dot 64 dot 1305311650090 dot 9860 at digraph dot polyomino dot org dot uk> <20130531182119 dot GA30065 at domone dot kolej dot mff dot cuni dot cz>
On Fri, 31 May 2013, Ondrej Bilka wrote:
> On Fri, May 31, 2013 at 05:02:10PM +0000, Joseph S. Myers wrote:
> > For cases such as GLRO, GL and ElfW, where the macro call is more like a
> > variable or type name than a function call and almost universal practice
> > is not to have the space, I think additions of the spaces would need
> > discussing separately. (There might be other such cases as well.)
> >
> As macros are generaly uppercase we could remove space when uppercase.
But for some macros, the space insertion is appropriate - it's a matter of
the particular semantics whether or not it should be added (and for GLRO,
GL, ElfW I said to raise the matter in a separate thread if you think the
spaces should be added, rather than necessarily to avoid adding it).
--
Joseph S. Myers
joseph@codesourcery.com