This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix comment typos in libio/stdio.h
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Murilo Opsfelder Araujo <mopsfelder at gmail dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 22 May 2013 19:46:42 -0400
- Subject: Re: [PATCH] Fix comment typos in libio/stdio.h
- References: <1369262403-14172-1-git-send-email-mopsfelder at gmail dot com>
On 05/22/2013 06:40 PM, Murilo Opsfelder Araujo wrote:
> Hello,
>
> I have not completed FSF copyright assignment and I hope this is not a problem
> due the size of my patch (less than 15 lines).
It is not a problem, and thank you very much for contributing
to the project.
May I suggest you look over our todo list for something you
might find interesting?
http://sourceware.org/glibc/wiki/Development_Todo/Master
> This is my very first contribution to glibc and any feedback is welcome.
Unfortunately your patch is wrong.
While the constants say "*_MAX" they are actually minimums.
You are guaranteed at least TMP_MAX unique filenames.
You are guaranteed at least FOPEN_MAX files open simultaneously.
Their names are lamentably confusing but part of the standard.
Cheers,
Carlos.