This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Update bits/siginfo.h with Linux hwpoison SIGBUS changes
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Edjunior Barbosa Machado <emachado at linux dot vnet dot ibm dot com>
- Cc: carlos at redhat dot com, aj at suse dot com, libc-alpha at sourceware dot org, libc-ports at sourceware dot org, naveen dot n dot rao at linux dot vnet dot ibm dot com
- Date: Thu, 16 May 2013 17:43:47 -0700 (PDT)
- Subject: Re: [PATCH] Update bits/siginfo.h with Linux hwpoison SIGBUS changes
- References: <5192A25A dot 1060406 at redhat dot com> <1368600683-11773-1-git-send-email-emachado at linux dot vnet dot ibm dot com>
Always write 'short int', never just 'short'. Otherwise these seem fine to
me (assuming they match the new kernel definitions).
The ports changes technically need pro forma sign-off from four
maintainers. But I think it's good enough if you've triple-checked that
the new definitions match the kernel's for each machine, and wait a few
days to give them a chance to speak up, but go ahead and commit (say, on
Tuesday) for each port whose maintainer hasn't responded. You can commit
the common change now (and each port's change as soon as the maintainer
says), or wait to do them all together, at your pleasure.
Thanks,
Roland