This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [COMMITTED] Add comments for processing extra pseudo-hwcaps from vDSOs.


> +	    /* The standard ELF note layout is exactly as the anonymous struct.
> +	       The next element is a variable length vendor name of length
> +	       VENDORLEN (with a real length rounded to ElfW(Addr)), followed
> +	       by the data of length DATALEN (with a real length rounded to
> +	       ElfW(Addr)).  */

Actually those sizes are rounded up to ElfW(Word), which is to say, always
four bytes.  The note header fields are four bytes even in ELFCLASS64.

> +  /* Is this a normal hwcap for the machine e.g. fpu?  */

This is a run-on sentence with no punctuation before "e.g."
Either a comma, or parenthesizing the "e.g. clause", would be appropriate.
(Same issue occurs twice more below.)

> +  /* The last entry in hwcap_extra is reserved for the "tls"
> +     pseudo-hwcap which indicates support for TLS.  */
>    hwcap_extra[63 - _DL_FIRST_EXTRA] = "tls";

Perhaps say here that this seemingly pointless addition is for
compatibility with the directory layout needed for old versions,
where "tls" was actually optional.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]