This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Update s390/bits/siginfo.h
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Edjunior Barbosa Machado <emachado at linux dot vnet dot ibm dot com>, Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- Cc: aj at suse dot com, libc-alpha at sourceware dot org, naveen dot n dot rao at linux dot vnet dot ibm dot com
- Date: Wed, 15 May 2013 10:57:42 -0400
- Subject: Re: [PATCH] Update s390/bits/siginfo.h
- References: <1368600831-11875-1-git-send-email-emachado at linux dot vnet dot ibm dot com>
On 05/15/2013 02:53 AM, Edjunior Barbosa Machado wrote:
> Updated patch with the comments fixed, following suggestions from Andreas and
> Carlos.
>
> Thanks for the feedback.
> --
> Edjunior
>
> ChangeLog:
> 2013-05-15 Edjunior Machado <emachado@linux.vnet.ibm.com>
>
> * sysdeps/unix/sysv/linux/s390/bits/siginfo.h (siginfo_t): Remove
> si_trapno and add si_addr_lsb to _sifields.sigfault.
> (si_trapno): Remove macro.
> (si_addr_lsb): Define new macro.
> (BUS_MCEERR_AR, BUS_MCEERR_AO): Define new values.
OK. Th s390 maintainer should ACK.
> ---
> sysdeps/unix/sysv/linux/s390/bits/siginfo.h | 10 +++++++---
> 1 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/sysdeps/unix/sysv/linux/s390/bits/siginfo.h b/sysdeps/unix/sysv/linux/s390/bits/siginfo.h
> index ad12208..19c94e7 100644
> --- a/sysdeps/unix/sysv/linux/s390/bits/siginfo.h
> +++ b/sysdeps/unix/sysv/linux/s390/bits/siginfo.h
> @@ -95,7 +95,7 @@ typedef struct
> struct
> {
> void *si_addr; /* Faulting insn/memory ref. */
> - int si_trapno;
> + short si_addr_lsb; /* Valid LSB of the reported address. */
> } _sigfault;
>
> /* SIGPOLL. */
> @@ -128,7 +128,7 @@ typedef struct
> # define si_int _sifields._rt.si_sigval.sival_int
> # define si_ptr _sifields._rt.si_sigval.sival_ptr
> # define si_addr _sifields._sigfault.si_addr
> -# define si_trapno _sifields._sigfault.si_trapno
> +# define si_addr_lsb _sifields._sigfault.si_addr_lsb
> # define si_band _sifields._sigpoll.si_band
> # define si_fd _sifields._sigpoll.si_fd
> # define si_call_addr _sifields._sigsys._call_addr
> @@ -219,8 +219,12 @@ enum
> # define BUS_ADRALN BUS_ADRALN
> BUS_ADRERR, /* Non-existant physical address. */
> # define BUS_ADRERR BUS_ADRERR
> - BUS_OBJERR /* Object specific hardware error. */
> + BUS_OBJERR, /* Object specific hardware error. */
> # define BUS_OBJERR BUS_OBJERR
> + BUS_MCEERR_AR, /* Hardware memory error: action required. */
> +# define BUS_MCEERR_AR BUS_MCEERR_AR
> + BUS_MCEERR_AO /* Hardware memory error: action optional. */
> +# define BUS_MCEERR_AO BUS_MCEERR_AO
> };
>
> /* `si_code' values for SIGTRAP signal. */
>