This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/9] Add the low level infrastructure for pthreads lock elision with TSX
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Andreas Jaeger <aj at suse dot com>
- Cc: Andi Kleen <ak at linux dot intel dot com>, libc-alpha at sourceware dot org
- Date: Tue, 14 May 2013 03:27:44 -0400
- Subject: Re: [PATCH 2/9] Add the low level infrastructure for pthreads lock elision with TSX
- References: <1368225725-14283-1-git-send-email-andi at firstfloor dot org> <1368225725-14283-3-git-send-email-andi at firstfloor dot org> <518F5B45 dot 6080301 at suse dot com> <20130513223037 dot GG4072 at tassilo dot jf dot intel dot com> <5191E43C dot 7070602 at suse dot com>
On 05/14/2013 03:14 AM, Andreas Jaeger wrote:
> On 05/14/2013 12:30 AM, Andi Kleen wrote:
>>>> + {
>>>> + char *end;
>>>> + int val;
>>>> +
>>>> + if (s[nlen] != '=')
>>>> + {
>>>> + complain (PAIR ("pthreads: invalid GLIBC_MUTEX syntax: missing =\n"));
>>>
>>> These warnings are not localized - can/want we have them localized?
>>
>> I doubt the locale facility is up at this point.
>> pthreads initialization is very early and I had a lot of problems
>> with such dependencies.
>
> That's what I feared - if that's the case, ignore my comments ;)
I disbelieve this.
This code is run from elision_init which is in .init_array or .preinit_array.
You should have all the functionality of the C library by that point?
Don't C++ static constructors are run from these?
What problems did you have localizing this?
Cheers,
Carlos.