This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/5] Move _obstack_compat out of common
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Peter Collingbourne <pcc at google dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 13 May 2013 18:09:33 +0200
- Subject: Re: [PATCH 2/5] Move _obstack_compat out of common
- References: <1368459372-2415-1-git-send-email-pcc at google dot com> <1368459372-2415-3-git-send-email-pcc at google dot com>
On Mon, May 13, 2013 at 08:36:09AM -0700, Peter Collingbourne wrote:
> It is impossible to create an alias of a common symbol (as
> compat_symbol does), because common symbols do not have a section or
> an offset until linked. GNU as tolerates aliases of common symbols by
> simply creating another common symbol, but other assemblers (notably
> LLVM's integrated assembler) are less tolerant.
>
> /* A looong time ago (before 1994, anyway; we're not sure) this global variable
> was used by non-GNU-C macros to avoid multiple evaluation. The GNU C
> library still exports it because somebody might use it. */
That I call compatibility :)
> -struct obstack *_obstack_compat;
> +struct obstack *_obstack_compat = 0;
OK for me.
Ondra