This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Convert TEST_f_f tests from code to data


On Mon, 13 May 2013, Adhemerval Zanella wrote:

> On 05/12/2013 03:42 PM, Joseph S. Myers wrote:
> > On Sun, 12 May 2013, Adhemerval Zanella wrote:
> >
> >> I didn't dig into, but it shows on GCC 4.4.6, 4.7.4, and trunk (4.9). To 
> >> avoid more compiler ifdefs, I suggest just replace it to a constant. 
> >> Tested on PowerPC and PowerPC64.
> > I suggest defining a macro with this constant value along with the other 
> > M_* macros defined in libc-test.inc (whose definitions I made into decimal 
> > constants to avoid this sort of issue with GCC bug 26374: 
> > <http://sourceware.org/ml/libc-alpha/2013-05/msg00221.html>), rather than 
> > using the long constant directly as a test input.
> >
> I updated the patch with a macro, ok to apply?

This is OK.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]