This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Convert TEST_f_f tests from code to data
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 13 May 2013 15:41:16 +0000
- Subject: Re: Convert TEST_f_f tests from code to data
- References: <Pine dot LNX dot 4 dot 64 dot 1305102059161 dot 3435 at digraph dot polyomino dot org dot uk> <518DD395 dot 6040600 at suse dot com> <518FDFC7 dot 7030008 at linux dot vnet dot ibm dot com> <Pine dot LNX dot 4 dot 64 dot 1305121840570 dot 19219 at digraph dot polyomino dot org dot uk> <5190D7AC dot 3010202 at linux dot vnet dot ibm dot com>
On Mon, 13 May 2013, Adhemerval Zanella wrote:
> On 05/12/2013 03:42 PM, Joseph S. Myers wrote:
> > On Sun, 12 May 2013, Adhemerval Zanella wrote:
> >
> >> I didn't dig into, but it shows on GCC 4.4.6, 4.7.4, and trunk (4.9). To
> >> avoid more compiler ifdefs, I suggest just replace it to a constant.
> >> Tested on PowerPC and PowerPC64.
> > I suggest defining a macro with this constant value along with the other
> > M_* macros defined in libc-test.inc (whose definitions I made into decimal
> > constants to avoid this sort of issue with GCC bug 26374:
> > <http://sourceware.org/ml/libc-alpha/2013-05/msg00221.html>), rather than
> > using the long constant directly as a test input.
> >
> I updated the patch with a macro, ok to apply?
This is OK.
--
Joseph S. Myers
joseph@codesourcery.com