This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH 3/5] Use x constraints for operands to vfmaddss and vfmaddsd
- From: Peter Collingbourne <pcc at google dot com>
- To: libc-alpha at sourceware dot org
- Cc: Peter Collingbourne <pcc at google dot com>
- Date: Mon, 13 May 2013 08:36:10 -0700
- Subject: [PATCH 3/5] Use x constraints for operands to vfmaddss and vfmaddsd
- References: <1368459372-2415-1-git-send-email-pcc at google dot com>
While these instructions accept memory operands, only one operand
may be a memory operand. Giving two operands xm constraints gives
the compiler the option of using memory for both operands, which
would result in invalid assembly code. Using x for all operands is
more appropriate, as most x86_64 calling conventions will pass the
arguments in registers anyway.
2013-05-13 Peter Collingbourne <pcc@google.com>
* sysdeps/x86_64/fpu/multiarch/s_fma.c (__fma_fma4): Replace xm
constraints with x constraints.
* sysdeps/x86_64/fpu/multiarch/s_fmaf.c (__fmaf_fma4): Likewise.
---
sysdeps/x86_64/fpu/multiarch/s_fma.c | 2 +-
sysdeps/x86_64/fpu/multiarch/s_fmaf.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sysdeps/x86_64/fpu/multiarch/s_fma.c b/sysdeps/x86_64/fpu/multiarch/s_fma.c
index ea18559..25a306f 100644
--- a/sysdeps/x86_64/fpu/multiarch/s_fma.c
+++ b/sysdeps/x86_64/fpu/multiarch/s_fma.c
@@ -38,7 +38,7 @@ __fma_fma3 (double x, double y, double z)
static double
__fma_fma4 (double x, double y, double z)
{
- asm ("vfmaddsd %3, %2, %1, %0" : "=x" (x) : "x" (x), "xm" (y), "xm" (z));
+ asm ("vfmaddsd %3, %2, %1, %0" : "=x" (x) : "x" (x), "x" (y), "x" (z));
return x;
}
# else
diff --git a/sysdeps/x86_64/fpu/multiarch/s_fmaf.c b/sysdeps/x86_64/fpu/multiarch/s_fmaf.c
index 9647d79..063be69 100644
--- a/sysdeps/x86_64/fpu/multiarch/s_fmaf.c
+++ b/sysdeps/x86_64/fpu/multiarch/s_fmaf.c
@@ -37,7 +37,7 @@ __fmaf_fma3 (float x, float y, float z)
static float
__fmaf_fma4 (float x, float y, float z)
{
- asm ("vfmaddss %3, %2, %1, %0" : "=x" (x) : "x" (x), "xm" (y), "xm" (z));
+ asm ("vfmaddss %3, %2, %1, %0" : "=x" (x) : "x" (x), "x" (y), "x" (z));
return x;
}
# else
--
1.8.2.1