On 04/11/2013 10:36 PM, Roland McGrath wrote:
May I commit this if I adjust the ChangeLog and mention the bug in NEWS?
The change is OK with the BZ# in the log entry. But I don't think the bug
should be marked closed until we make all the programs consistent in using
*stat64 everywhere. So it would be better if you can just post a new
version of the patch that covers everything.
Do you refer to libc-internal uses of *stat, or the use of 64-bit
interfaces in the helper programs?
They are separable issues. For now we are just talking about programs.
In the latter case, it probably makes sense to compile them with
-D_FILE_OFFSET_BITS=64, making the existing patch redundant.
That is a sensible approach in the abstract. But given the status quo of
how everything gets built, it would be much more involved and fragile to
attempt that change now.