This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Use correct TEST_* macros for jn, ldexp and yn tests
- From: Andreas Jaeger <aj at suse dot com>
- To: libc-alpha at sourceware dot org
- Date: Wed, 08 May 2013 17:48:56 +0200
- Subject: Re: Use correct TEST_* macros for jn, ldexp and yn tests
- References: <Pine dot LNX dot 4 dot 64 dot 1305081523370 dot 23379 at digraph dot polyomino dot org dot uk>
On 05/08/2013 05:24 PM, Joseph S. Myers wrote:
The libm-test.inc tests for jn, ldexp and yn use the wrong TEST_*
calls to run the tests, using TEST_ff_f (two floating-point inputs,
one floating-point output) when one of the inputs is of type int.
(Because the argument strings passed end up directly inside a call to
the relevant function, this mistake doesn't cause any visible effects,
but with the move to table-driven tests separate struct types will be
used in each case, although the relevant macro definitions can still
be shared.) This patch fixes these tests to use the appropriate
TEST_if_f and TEST_fi_f instead. Tested x86_64.
Ooops - thanks for catching that. This is fine,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126