This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix _nl_find_msg malloc failure case, and callers.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 07 May 2013 17:14:56 -0400
- Subject: Re: [PATCH] Fix _nl_find_msg malloc failure case, and callers.
- References: <51892FCE dot 5030506 at redhat dot com> <Pine dot LNX dot 4 dot 64 dot 1305071711540 dot 22763 at digraph dot polyomino dot org dot uk>
On 05/07/2013 01:14 PM, Joseph S. Myers wrote:
> On Tue, 7 May 2013, Carlos O'Donell wrote:
>
>> This patch fixes two issues, and perhaps should be two distinct patches,
>> but I present it here as one for the sake of completeness.
>
> There should be at least one bug in Bugzilla for this, if the issues fixed
> are user-visible in some way.
Thanks for the reminder. Created BZ#15441.
> Also, the intl/ code is shared with GNU gettext; I don't know how much
> divergence there has been on each side since they were last in sync, but
> if the patch is plausibly applicable to the version in GNU gettext,
> sending it there would be a good idea.
It is applicable.
There is quite a bit of divergence too.
Bug filed with GNU gettext:
https://savannah.gnu.org/bugs/index.php?38930
The patch had to change only a little to apply upstream.
The broader question is: What are we going to do about
synchronizing with GNU gettext? :-(
Cheers,
Carlos.