This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use *stat64 instead of *stat in installed programs
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Fri, 12 Apr 2013 12:55:38 -0700 (PDT)
- Subject: Re: [PATCH] Use *stat64 instead of *stat in installed programs
- References: <515BE8AA dot 6010407 at redhat dot com> <Pine dot LNX dot 4 dot 64 dot 1304031447110 dot 580 at digraph dot polyomino dot org dot uk> <515C4AB7 dot 7010205 at redhat dot com> <516518D2 dot 4070606 at redhat dot com> <20130411203606 dot C8C302C086 at topped-with-meat dot com> <5167BB8D dot 2030206 at redhat dot com>
> On 04/11/2013 10:36 PM, Roland McGrath wrote:
> >> May I commit this if I adjust the ChangeLog and mention the bug in NEWS?
> >
> > The change is OK with the BZ# in the log entry. But I don't think the bug
> > should be marked closed until we make all the programs consistent in using
> > *stat64 everywhere. So it would be better if you can just post a new
> > version of the patch that covers everything.
>
> Do you refer to libc-internal uses of *stat, or the use of 64-bit
> interfaces in the helper programs?
They are separable issues. For now we are just talking about programs.
> In the latter case, it probably makes sense to compile them with
> -D_FILE_OFFSET_BITS=64, making the existing patch redundant.
That is a sensible approach in the abstract. But given the status quo of
how everything gets built, it would be much more involved and fragile to
attempt that change now.
Thanks,
Roland