This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Move bench target into benchtests
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: Andreas Schwab <schwab at linux-m68k dot org>, Roland McGrath <roland at hack dot frob dot com>, libc-alpha at sourceware dot org
- Date: Wed, 10 Apr 2013 23:41:03 -0400
- Subject: Re: [PATCH] Move bench target into benchtests
- References: <20130403080526 dot GA20842 at spoyarek dot pnq dot redhat dot com> <20130408220956 dot 124492C09F at topped-with-meat dot com> <20130409044525 dot GD15689 at spoyarek dot pnq dot redhat dot com> <m2mwt6t53s dot fsf at igel dot home> <20130411033922 dot GC8531 at spoyarek dot pnq dot redhat dot com>
On 04/10/2013 11:39 PM, Siddhesh Poyarekar wrote:
> On Thu, Apr 11, 2013 at 12:04:23AM +0200, Andreas Schwab wrote:
>> Siddhesh Poyarekar <siddhesh@redhat.com> writes:
>>
>>> +run-bench = $(test-wrapper-env) \
>>> + GCONV_PATH=$(common-objpfx)iconvdata LC_ALL=C \
>>> + $($*-ENV) $(run-via-rtld-prefix) $${run}
>>
>> You cannot use $(run-via-rtld-prefix) here. It uses built-program-file
>> which assumes that $(word 2,$^) is the program binary.
>>
>
> Right, how about this patch to first fix this. I'll do the
> move on top of this.
>
> Siddhesh
>
> commit e8051d2923fb87214c3a641a7b495eb4315e8f53
> Author: Siddhesh Poyarekar <siddhesh@redhat.com>
> Date: Thu Apr 11 09:06:40 2013 +0530
>
> Don't use run-via-rtld-prefix for anything other than tests
>
> run-via-rtld-prefix checks whether the program to be run is a static
> test and skips if it is. This is fine, except that it assumes that
> the program to be run is the second $^, which is true only for tests.
>
> This change creates an rtld-prefix, which is simply the dynamic linker
> prefix with the necessary arguments and uses that in the non-test
> targets.
>
> * Makeconfig (rtld-prefix): Define built linker prefix.
> * Rules (run-bench): Use it.
> * math/Makefile (run-regen-ulps): Likewise.
Looks good to me, thanks for fixing run-regen-ulps.
Cheers,
Carlos.