This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Move bench target into benchtests


On 04/09/2013 09:44 AM, Siddhesh Poyarekar wrote:
> On Tue, Apr 09, 2013 at 09:38:27AM -0400, Carlos O'Donell wrote:
>>> +bench: $(binaries-bench)
>>> +	for run in $^; do \
>>> +	  echo "Running $${run}"; \
>>> +	  eval $(run-bench) >>  $(objpfx)bench.out-tmp; \
>>
>> Do you need `eval' here? Schwab caught this in my implementation also,
>> and I didn't need it because all the variables were resolved by the time
>> the command is evaluated.
>>
> 
> Tulio had added it IIRC to get it to work on powerpc.  I'll check if
> it is in fact needed and if not, I'll just remove it.

Did he use a cross-test wrapper?

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]