This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2][BZ #15339] Avoid returning EAI_SYSTEM when there's a network error
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: libc-alpha at sourceware dot org
- Date: Tue, 9 Apr 2013 22:27:05 +0530
- Subject: Re: [PATCH v2][BZ #15339] Avoid returning EAI_SYSTEM when there's a network error
- References: <20130401171156 dot GB9522 at altlinux dot org> <CAAHN_R1yThAuKHrr4cePcmrVo_=vHLf9257OGFsE6v3Oc36s4Q at mail dot gmail dot com> <20130402134937 dot GB3211 at altlinux dot org> <20130408033614 dot GA20503 at altlinux dot org> <20130408052713 dot GB32556 at spoyarek dot pnq dot redhat dot com> <20130408055825 dot GA21873 at altlinux dot org> <20130408063238 dot GG32556 at spoyarek dot pnq dot redhat dot com> <20130408174239 dot GA26714 at altlinux dot org> <20130409113848 dot GL15689 at spoyarek dot pnq dot redhat dot com> <20130409165018 dot GA3440 at altlinux dot org>
On Tue, Apr 09, 2013 at 08:50:19PM +0400, Dmitry V. Levin wrote:
> > Siddhesh
> >
> > [BZ #15339]
> > * nss/getXXbyYY_r.c (REENTRANT_NAME): Set NETDB_INTERNAL only
> > when no services were used.
> > * sysdeps/posix/getaddrinfo.c (gaih_inet): Set h_errno.
> > Return EAI_SYSTEM if h_errno is NETDB_INTERNAL.
>
> Looks good and passes all my test cases. Thanks,
>
Thanks for testing this. I'd like it if one more maintainer could
review the patch and rationale behind my changes. The resolver code
is convoluted (in an unbearably horrible way) enough that I may have
again broken something and not realized it.
Siddhesh