This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Ping: [PATCH v4] faster strlen on x64
On Tue, Mar 12, 2013 at 09:24:07AM -0400, Carlos O'Donell wrote:
> On 03/11/2013 05:15 AM, OndÅej BÃlka wrote:
> > Carlos, what is you opinion?
>
> The patch looks good. I have one last question though.
>
> We remove some interesting code in the existing strlen implementations
> that ensure that strlen calls from libc itself do not go through the PLT.
>
> Have you verified that after your changes there are no testsuite regressions
> in the plt check test or that the internal calls to strlen avoid the PLT?
>
I have libc_hidden_builtin_def PLT there. Is not that sufficient?
My understanding was that code was used to avoid PLT in ifunc.
P.S. is somewhere documentated difference between libc_hidden_def and
libc_hidden_builtin_def?
> OK to checkin after this additional validation with posted result.
>
> Cheers,
> Carlos.