This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Further cleanup of bits/mman.h
On 03/06/2013 03:23 PM, Andreas Krebbel wrote:
> On 05/03/13 19:54, Andreas Jaeger wrote:
>> On 03/05/2013 03:32 PM, Andreas Krebbel wrote:
>>> On 04/03/13 20:40, Andreas Jaeger wrote:
>>>>
>>>> As suggested by Carlos, I'm moving MCL_CURRENT and MCL_FUTURE to
>>>> <bits/mman-linux.h> as well and define it unless it's already defined.
>>>>
>>>> Ok to commit?
>>>
>>> S/390 bits are ok. Thanks!
>>
>> Andreas, could you review these values in the s390 version:
>>
>> # define MAP_GROWSDOWN 0x00100 /* Stack-like segment. */
>> // XXX? Not defined in Linux kernel 3.8
>> # define MAP_GROWSUP 0x00200 /* Register stack-like segment */
>>
>> Why are both defined - especially as the kernel only has GROWSDOWN?
>
> The MAP_GROWSUP definition can go away. Thanks!
Ok, here's what I committed now,
Andreas
2013-03-06 Andreas Jaeger <aj@suse.de>
* sysdeps/unix/sysv/linux/s390/bits/mman.h (MAP_GROWSUP): Remove,
it's not part of Linux headers.
diff --git a/sysdeps/unix/sysv/linux/s390/bits/mman.h b/sysdeps/unix/sysv/linux/s390/bits/mman.h
index 3a65ba1..b788fa5 100644
--- a/sysdeps/unix/sysv/linux/s390/bits/mman.h
+++ b/sysdeps/unix/sysv/linux/s390/bits/mman.h
@@ -27,8 +27,6 @@
/* These are Linux-specific. */
#ifdef __USE_MISC
# define MAP_GROWSDOWN 0x00100 /* Stack-like segment. */
-// XXX? Not defined in Linux kernel 3.8
-# define MAP_GROWSUP 0x00200 /* Register stack-like segment */
# define MAP_DENYWRITE 0x00800 /* ETXTBSY */
# define MAP_EXECUTABLE 0x01000 /* Mark it as an executable. */
# define MAP_LOCKED 0x02000 /* Lock the mapping. */
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126