This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Add one test, removed a duplicated one, add a few comments about missing tests.


	* math/libm-test.inc (acosh_test): Also test with qNaN input.
	(sqrt_test): Remove duplicate test with qNaN input.
	(lrint_test, llrint_test, lround_test, llround_test, rint_test)
	(round_test, signbit_test, significand_test): Note missing +/-Inf
	as well as qNaN tests.
---
 math/libm-test.inc |   16 +++++++++++++++-
 1 files changed, 15 insertions(+), 1 deletions(-)

diff --git math/libm-test.inc math/libm-test.inc
index 5db3b63..b5a179e 100644
--- math/libm-test.inc
+++ math/libm-test.inc
@@ -972,6 +972,7 @@ acosh_test (void)
 
   TEST_f_f (acosh, plus_infty, plus_infty);
   TEST_f_f (acosh, minus_infty, qnan_value, INVALID_EXCEPTION);
+  TEST_f_f (acosh, qnan_value, qnan_value);
 
   /* x < 1:  */
   TEST_f_f (acosh, -1.125L, qnan_value, INVALID_EXCEPTION);
@@ -6441,6 +6442,7 @@ lrint_test (void)
   /* XXX this test is incomplete.  We need to have a way to specifiy
      the rounding method and test the critical cases.  So far, only
      unproblematic numbers are tested.  */
+  /* TODO: missing +/-Inf as well as qNaN tests.  */
 
   START (lrint);
 
@@ -6633,6 +6635,7 @@ llrint_test (void)
   /* XXX this test is incomplete.  We need to have a way to specifiy
      the rounding method and test the critical cases.  So far, only
      unproblematic numbers are tested.  */
+  /* TODO: missing +/-Inf as well as qNaN tests.  */
 
   START (llrint);
 
@@ -7511,6 +7514,8 @@ logb_test_downward (void)
 static void
 lround_test (void)
 {
+  /* TODO: missing +/-Inf as well as qNaN tests.  */
+
   START (lround);
 
   TEST_f_l (lround, 0, 0);
@@ -7553,6 +7558,8 @@ lround_test (void)
 static void
 llround_test (void)
 {
+  /* TODO: missing +/-Inf as well as qNaN tests.  */
+
   START (llround);
 
   TEST_f_L (llround, 0, 0);
@@ -8878,6 +8885,8 @@ remquo_test (void)
 static void
 rint_test (void)
 {
+  /* TODO: missing qNaN tests.  */
+
   START (rint);
 
   TEST_f_f (rint, 0.0, 0.0);
@@ -9343,6 +9352,8 @@ rint_test_upward (void)
 static void
 round_test (void)
 {
+  /* TODO: missing +/-Inf as well as qNaN tests.  */
+
   START (round);
 
   TEST_f_f (round, 0, 0);
@@ -9584,6 +9595,7 @@ scalbln_test (void)
 static void
 signbit_test (void)
 {
+  /* TODO: missing qNaN tests.  */
 
   START (signbit);
 
@@ -10004,7 +10016,6 @@ sqrt_test (void)
   TEST_f_f (sqrt, -1, qnan_value, INVALID_EXCEPTION);
   TEST_f_f (sqrt, -max_value, qnan_value, INVALID_EXCEPTION);
   TEST_f_f (sqrt, minus_infty, qnan_value, INVALID_EXCEPTION);
-  TEST_f_f (sqrt, qnan_value, qnan_value);
 
   TEST_f_f (sqrt, 2209, 47);
   TEST_f_f (sqrt, 4, 2);
@@ -10600,6 +10611,9 @@ static void
 significand_test (void)
 {
   /* significand returns the mantissa of the exponential representation.  */
+
+  /* TODO: missing +/-Inf as well as qNaN tests.  */
+
   START (significand);
 
   TEST_f_f (significand, 4.0, 1.0);
-- 
1.7.4.1


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]