This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Generally use underscore-pre-/-postfixed attributes? (was: GNU C Library master sources branch master updated. glibc-2.17-262-gf6432d8)


Hi!

On 20 Feb 2013 15:56:36 -0000, I wrote:
> commit c7b275d6b3bceb6b400fa3044d13d1001bc605ca
> Author: Thomas Schwinge <thomas@codesourcery.com>
> Date:   Tue Feb 19 13:06:39 2013 +0100
> 
>     bits/nan.h: Change __attribute_used__ to __attribute__ ((unused)).

Joseph reminded me that __attribute__ ((unused)) is not appropriate; it
needs to be __attribute__ ((__unused__)) in installed headers, as the
former tampers with the user namespace.

Should we perhaps generally use the underscore-pre-/-postfixed form of
attributes in all of glibc's source files to not have to worry about
installed/not installed headers?  Or is that overkill?


GrÃÃe,
 Thomas

Attachment: pgp00000.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]