This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH] Remove dead CFLAGS from string/Makefile
- From: Tom de Vries <Tom_deVries at mentor dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Mon, 11 Feb 2013 22:07:43 +0100
- Subject: [PATCH] Remove dead CFLAGS from string/Makefile
Hi,
In this commit the files string/bug-strstr1.c and string/bug-strcasestr1.c were
removed, but the corresponding CFLAGS lines in string/Makefile were not removed:
...
2012-10-05 H.J. Lu <hongjiu.lu@intel.com>
[BZ #14602]
* string/test-strstr.c (check2): New function.
(test_main): Call check2.
* string/Makefile (tests): Remove bug-strstr1, bug-strcasestr1
and bug-strchr1.
* string/bug-strcasestr1.c (do_test): Moved to ...
* string/test-strcasestr.c (check1): Here. New function.
(do_one_test): Break out result checking code into ...
(check_result): This. New function.
(do_one_test): Call check_result.
(test_main): Call check1.
* string/bug-strchr1.c (do_test): Moved to ...
* string/test-strchr.c (check1): Here. New function.
(do_one_test): Break out result checking code into ...
(check_result): This. New function.
(do_one_test): Call check_result.
(test_main): Call check1.
* string/bug-strstr1.c (main): Moved to ...
* string/test-strstr.c (check1): Here. New function.
(do_one_test): Break out result checking code into ...
(check_result): This. New function.
(do_one_test): Call check_result.
(test_main): Call check1.
* string/bug-strcasestr1.c: Removed.
* string/bug-strchr1.c: Likewise.
* string/bug-strstr1.c: Likewise.
...
This patch removes the now dead CFLAGS lines.
I think this is a trivial change, so I'll commit this shortly.
Thanks,
- Tom
2013-02-11 Tom de Vries <tom@codesourcery.com>
* string/Makefile (CFLAGS-bug-strstr1.c, CFLAGS-bug-strcasestr1.c):
Remove.
diff --git a/string/Makefile b/string/Makefile
index 44bbd0c..894bae4 100644
--- a/string/Makefile
+++ b/string/Makefile
@@ -75,8 +75,6 @@ CFLAGS-tst-strlen.c = -fno-builtin
CFLAGS-stratcliff.c = -fno-builtin
CFLAGS-test-ffs.c = -fno-builtin
CFLAGS-tst-inlcall.c = -fno-builtin
-CFLAGS-bug-strstr1.c = -fno-builtin
-CFLAGS-bug-strcasestr1.c = -fno-builtin
ifeq ($(run-built-tests),yes)
tests: $(objpfx)tst-svc.out