This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[COMMITTED] Expand comment on _dl_cache_lookup.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 08 Feb 2013 12:53:17 -0500
- Subject: [COMMITTED] Expand comment on _dl_cache_lookup.
Team,
While working on the cache routines I found it useful to remember that
a failure to load the cache file is permanent and that even
_dl_unload_cache won't reset the failure.
I've added a small comments to _dl_load_cache_lookup to remind anyone
else reviewing the same code.
Checked in.
2013-02-07 Carlos O'Donell <carlos@redhat.com>
* elf/dl-cache.c (_dl_load_cache_lookup): Comment that cache is
loaded if not already and that a failure is permanent.
diff --git a/elf/dl-cache.c b/elf/dl-cache.c
index 2c4bcc6..030fdca 100644
--- a/elf/dl-cache.c
+++ b/elf/dl-cache.c
@@ -172,8 +172,9 @@ _dl_cache_libcmp (const char *p1, const char *p2)
}
-/* Look up NAME in ld.so.cache and return the file name stored there,
- or null if none is found. */
+/* Look up NAME in ld.so.cache and return the file name stored there, or null
+ if none is found. The cache is loaded if it was not already. If loading
+ the cache previously failed there will be no more attempts to load it. */
const char *
internal_function
---