This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] scsi/sg.h: include sys/types.h for size_t


On Sunday 13 January 2013 11:57:35 Carlos O'Donell wrote:
> On 01/12/2013 06:53 PM, Mike Frysinger wrote:
> > This header uses size_t but doesn't include sys/types.h for it.  So when
> > packages happen to include this before any header that defines size_t,
> > they get a build failure.
> > 
> > --- a/sysdeps/unix/sysv/linux/scsi/sg.h
> > +++ b/sysdeps/unix/sysv/linux/scsi/sg.h
> >
> > +#include <sys/types.h>
> 
> Can we get away with `#include <stddef.h>'? That's the minimal
> header you need if you just want size_t. I'd like to avoid
> pulling in more than required.

should be ok.  i reached for sys/types.h since i knew it'd work.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]