This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Don't treat tls_offset == 1 as forced dynamic

From: Jeff Law <law at redhat dot com>
To: Andreas Schwab <schwab at suse dot de>
Cc: libc-alpha at sourceware dot org
Date: Wed, 05 Dec 2012 21:51:03 -0700
Subject: Re: [PATCH] Don't treat tls_offset == 1 as forced dynamic
References: <mvmd2yq6tbx.fsf@g208.suse.de>

On 12/04/2012 02:48 AM, Andreas Schwab wrote:

A TLS offset of 1 is a valid one, so it cannot be used as a marker to
force dynamic tls block allocation.  A valid tls_offset is never
negative, so use -1 as the marker instead.

Andreas.

	[BZ #14898]
	* include/link.h (FORCED_DYNAMIC_TLS_OFFSET) [NO_TLS_OFFSET == 0]:
	Change to -1.

FYI for David M.

If we could get this into 2.17 it'd be useful. In addition to fixing 14898 it fixes a downstream bug in Fedora (731228). It's been in Fedora since Sept 2011.


Thanks,
Jeff

Follow-Ups:
- Re: [PATCH] Don't treat tls_offset == 1 as forced dynamic
  - From: David Miller

References:
- [PATCH] Don't treat tls_offset == 1 as forced dynamic
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]