This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] Fix incorrectly named __kernel_get_tbfreq VDSO function
- From: "Ryan S. Arnold" <ryan dot arnold at gmail dot com>
- To: "David S. Miller" <davem at davemloft dot net>
- Cc: libc-alpha <libc-alpha at sourceware dot org>, Anton Blanchard <anton at samba dot org>
- Date: Thu, 29 Nov 2012 15:07:30 -0600
- Subject: Re: [PATCH 1/2] Fix incorrectly named __kernel_get_tbfreq VDSO function
- References: <20120709112735.22c2e72b@kryten>
Hi David,
This patch slipped through my 2.17 pre-freeze roundup for PowerPC but
it's a correctness issue.
Without it Tulio Quites Machado's __ppc_get_timebase_freq function
ends up using the proc file system fallback for querying the timebase
frequency rather than the VSYSCALL, since the name doesn't match.
I'd like to check this in for 2.17 (after verification of course).
Ryan S. Arnold
On Sun, Jul 8, 2012 at 8:27 PM, Anton Blanchard <anton@samba.org> wrote:
>
> 2012-07-09 Anton Blanchard <anton@samba.org>
>
> * sysdeps/unix/sysv/linux/powerpc/init-first.c: Rename
> __kernel_vdso_get_tbfreq to __kernel_get_tbfreq
>
> ---
> sysdeps/unix/sysv/linux/powerpc/init-first.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: glibc/sysdeps/unix/sysv/linux/powerpc/init-first.c
> ===================================================================
> --- glibc.orig/sysdeps/unix/sysv/linux/powerpc/init-first.c 2012-06-25 09:44:29.203189704 +1000
> +++ glibc/sysdeps/unix/sysv/linux/powerpc/init-first.c 2012-06-25 09:53:03.315959250 +1000
> @@ -39,7 +39,7 @@ _libc_vdso_platform_setup (void)
>
> __vdso_clock_getres = _dl_vdso_vsym ("__kernel_clock_getres", &linux2615);
>
> - __vdso_get_tbfreq = _dl_vdso_vsym ("__kernel_vdso_get_tbfreq", &linux2615);
> + __vdso_get_tbfreq = _dl_vdso_vsym ("__kernel_get_tbfreq", &linux2615);
> }
>
> # define VDSO_SETUP _libc_vdso_platform_setup