This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch] [BZ 13761] Fix another unbound alloca
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: Jeff Law <law at redhat dot com>
- Cc: Andreas Jaeger <aj at suse dot com>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Thu, 29 Nov 2012 09:53:33 -0500
- Subject: Re: [Patch] [BZ 13761] Fix another unbound alloca
- References: <5034064B.9070103@redhat.com><20120821221812.B4EC52C0B2@topped-with-meat.com><50B68C60.9080002@redhat.com><50B70937.5000705@suse.com><50B70ED3.4070903@redhat.com>
On Thu, Nov 29, 2012 at 2:29 AM, Jeff Law <law@redhat.com> wrote:
> On 11/29/2012 12:05 AM, Andreas Jaeger wrote:
>>
>> On 11/28/2012 11:12 PM, Jeff Law wrote:
>>>
>>> To recap (from the BZ):
>>>
>>> nss_compat allocates buffer space on stack using alloca (and
>>> extend_alloca) for initgroup and keeps extending it to fit in larger
>>> lines. This breaks for cases where the number of members in a gorup
>>> are very large, causing the alloca reference to go beyond thread stack
>>> boundary. Siddhesh partially fixed this problem a while back, this
>>> patch completes the fix.
>>
>>
>> This looks fine to me,
>
> Thanks. David's call as to whether or not to pull this into 2.17; barring
> an explicit OK from him I'll hold off installing until after the tree is
> unfrozen.
Set the bug's milestone to 2.17 if you want it in 2.17.
I'll go through all of those milestone bugs to help Dave, and then
point him at the bugs.
Cheers,
Carlos.