This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Setting CFLAGS values in sysdeps makefiles


Hi!

On Wed, 28 Nov 2012 23:09:37 -0500, Mike Frysinger <vapier@gentoo.org> wrote:
> On Wednesday 28 November 2012 20:18:09 Joseph S. Myers wrote:
> > To make this sort of thing work, should the CFLAGS-* settings in
> > posix/Makefile be made to use "+=", or should they be moved higher up the
> > file, or the Rules inclusion moved down, or would some other approach be
> > best?  And is there any general rule for what order the contents of the
> > subdirectory Makefile (including the "include ../Makeconfig" and "include
> > ../Rules") should go in?

That's maybe best for Roland to answer.

> seems like relying on ordering can be fragile and we should just always use 
> +=.  it isn't like we have to worry about the variable being set in the 
> environment since "-" isn't a valid char in a variable name.

I concur.  

While Joseph's specific case is resolved then, there remains complexity
in the Makefile inclusion system: different things depending on the order
in which files are included.  I supposed this in turn affects the
placement of newly added flags, which may lead to problems if one file's
addition means to cancel another file's: Â-Wno-inline -Winline vs.
Â-Winline -Wno-inlineÂ.


GrÃÃe,
 Thomas

Attachment: pgp00000.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]