This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch] [BZ 13761] Fix another unbound alloca
- From: Andreas Jaeger <aj at suse dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Thu, 29 Nov 2012 08:05:27 +0100
- Subject: Re: [Patch] [BZ 13761] Fix another unbound alloca
- References: <5034064B.9070103@redhat.com> <20120821221812.B4EC52C0B2@topped-with-meat.com> <50B68C60.9080002@redhat.com>
On 11/28/2012 11:12 PM, Jeff Law wrote:
To recap (from the BZ):
nss_compat allocates buffer space on stack using alloca (and
extend_alloca) for initgroup and keeps extending it to fit in larger
lines. This breaks for cases where the number of members in a gorup
are very large, causing the alloca reference to go beyond thread stack
boundary. Siddhesh partially fixed this problem a while back, this
patch completes the fix.
This looks fine to me,
Thanks,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 NÃrnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix ImendÃrffer,HRB16746 (AG NÃrnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126