This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: BZ #14865: linker -z XXXX support isn't properly checked


On Wed, Nov 21, 2012 at 3:16 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Nov 21, 2012 at 12:03 PM, Carlos O'Donell
> <carlos@systemhalted.org> wrote:
>> On Wed, Nov 21, 2012 at 1:33 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:
>>> Hi,
>>>
>>> This patch uses "ld -v --help" to check if a linker -z XXXX is mentioned
>>> before trying gcc -Wl,-z,XXXX since GNU linker ignores unknown -z XXX
>>> option with a warning.  Tested on x86-64.  OK to install?
>>>
>>> Thanks.
>>>
>>>
>>> H.J.
>>> ---
>>> 2012-11-21  H.J. Lu  <hongjiu.lu@intel.com>
>>>
>>>         [BZ #14865]
>>>         * aclocal.m4 (LIBC_LINKER_FEATURE): New macro.
>>>         * configure.in: Use LIBC_LINKER_FEATURE to check -z nodelete,
>>>         -z nodlopen, -z initfirst and -z execstack support.
>>>         * configure: Regenerated.
>>
>> Several of the original checks used `-nostartfiles', but your new
>> LBIC_LINKER_FEATURE doesn't.
>>
>> Will that make any difference when bootstrapping?
>>
>> I think the idea of the patch is OK, but I'm worried about the
>> -nostartfiles difference.
>>
>
> -nostartfiles isn't irrelevant to linker check.  Here is a patch
> to add  -nostartfiles to LBIC_LINKER_FEATURE.  OK to
> install?
>
> Thanks.
>
> --
> H.J.
> ---
> 2012-11-21  H.J. Lu  <hongjiu.lu@intel.com>
>
>         [BZ #14865]
>         * aclocal.m4 (LIBC_LINKER_FEATURE): New macro.
>         * configure.in: Use LIBC_LINKER_FEATURE to check -z nodelete,
>         -z nodlopen, -z initfirst and -z execstack support.
>         * configure: Regenerated.

We are close to the freeze, but this is a build issue not a new
feature, so it's OK.

Please check this in ASAP such that we reduce configure file churn
near the freeze.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]