This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Ping[3]: [PATCH][BZ #11741] printf should return negative valueon I/O error
On Thu, 15 Nov 2012 22:22:26 -0500, Carlos wrote:
> Though when I look at the code I don't see that _IO_sputn
> can ever return EOF, so while your change is robust, it's
> not really required. As far as I see _IO_sputn is the same
> as _IO_default_xsputn, which always returns the number of
> bytes written.
>
> Therefore your changes to libio/iopadn.c and libio/iowpadn.c
> are superfluous.
>
> Can you please confirm that you need those changes?
Not for the fix, no. I made the changes because I wasn't sure if
returning 0 was expected behaviour or not. The original patch[1] works
just as well.
Siddhesh
[1] http://sourceware.org/ml/libc-alpha/2012-10/msg00497.html