This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add ldconfig cache tag handling for ARM hard-float ABI
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: Steve McIntyre <steve dot mcintyre at linaro dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 14 Nov 2012 22:42:26 -0500
- Subject: Re: [PATCH] Add ldconfig cache tag handling for ARM hard-float ABI
- References: <20121114154148.GA23962@einval.com><20121115014230.GE9328@einval.com>
On Wed, Nov 14, 2012 at 8:42 PM, Steve McIntyre
<steve.mcintyre@linaro.org> wrote:
> Hi folks,
>
> Initial core code for armhf ABI - allocate a tag number
> FLAG_ARM_HFABI and add code to handle it in ldconfig. Code to follow
> on libc-ports to handle parsing ELF flags and using the new tag.
>
> =====================================================================
>
> Add ldconfig cache tag handling for ARM hard-float ABI
>
> * sysdeps/generic/ldconfig.h (FLAG_ARM_HFABI): New macro.
> * elf/cache.c (print_entry): Print appropriate message for cache
> entries tagged with FLAG_ARM_HFABI.
Will this have any impact on other distributions that may have
a different value for FLAG_ARM_HFABI and support a mixed soft/hard
environment?
I guess that upon an update to an incompatible flag number they would
need to remove the old cache and recreate it?
> Signed-off-by: Steve McIntyre <steve.mcintyre@linaro.org>
> ---
> ChangeLog | 6 ++++++
> elf/cache.c | 3 +++
> sysdeps/generic/ldconfig.h | 1 +
> 3 files changed, 10 insertions(+)
>
> diff --git a/ChangeLog b/ChangeLog
> index f5a3645..962a2a7 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,9 @@
> +2012-11-15 Steve McIntyre <steve.mcintyre@linaro.org>
> +
> + * sysdeps/generic/ldconfig.h (FLAG_ARM_HFABI): New macro.
The ABI variants are all of the form FLAG_$ARCH_LIB$FOO.
Can we follow the same form here e.g. FLAG_ARM_LIBHF?
> + * elf/cache.c (print_entry): Print appropriate message for cache
> + entries tagged with FLAG_ARM_HFABI.
Overly verbose. I suggest `Print ",hard-float" for FLAG_ARM_LIBHF.'
> +
> 2012-11-14 Marcus Shawcroft <marcus.shawcroft@linaro.org>
>
> * io/Makefile (CFLAGS-open.c, CFLAGS-open64.c): Define.
> diff --git a/elf/cache.c b/elf/cache.c
> index db8b9fa..49aa9a6 100644
> --- a/elf/cache.c
> +++ b/elf/cache.c
Update copyright year.
> @@ -94,6 +94,9 @@ print_entry (const char *lib, int flag, unsigned int osversion,
> case FLAG_X8664_LIBX32:
> fputs (",x32", stdout);
> break;
> + case FLAG_ARM_HFABI:
> + fputs (",hard-float", stdout);
> + break;
> case 0:
> break;
> default:
> diff --git a/sysdeps/generic/ldconfig.h b/sysdeps/generic/ldconfig.h
> index ef3f4b9..1cffdc6 100644
> --- a/sysdeps/generic/ldconfig.h
> +++ b/sysdeps/generic/ldconfig.h
Please merge copyright years.
> @@ -34,6 +34,7 @@
> #define FLAG_MIPS64_LIBN32 0x0600
> #define FLAG_MIPS64_LIBN64 0x0700
> #define FLAG_X8664_LIBX32 0x0800
> +#define FLAG_ARM_HFABI 0x0900
See previous nit e.g. FLAG_ARM_LIBHF.
>
> /* Name of auxiliary cache. */
> #define _PATH_LDCONFIG_AUX_CACHE "/var/cache/ldconfig/aux-cache"
> --
Cheers,
Carlos.