This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Suppress incorrect link warnings for NSS symbols


> 	* grp/initgroups.c: use new macro.

Capitalize.

> When glibc is built with --enable-static-nss, the warning that
[...]

This kind of text usually goes before the ChangeLog fragment in a posting.

> +/* Warning for NSS functions, which don't require dlopen if glibc
> +   was built with --enable-static-nss.  */
> +#ifdef DO_STATIC_NSS
> +#define nss_interface_function(name)

It's "# define" inside #ifdef.

> +#else
> +#define nss_interface_function(name) static_link_warning(name)
> +#endif

Likewise, and space before paren on the rhs.

You may commit the change with those fixes and reports of successful builds
both with and without --enable-static-nss.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]