This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Suppress incorrect link warnings for NSS symbols
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Chris Metcalf <cmetcalf at tilera dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 30 Oct 2012 09:20:52 -0700 (PDT)
- Subject: Re: [PATCH v2] Suppress incorrect link warnings for NSS symbols
- References: <201210300322.q9U3M91g012571@farm-0002.internal.tilera.com>
> * grp/initgroups.c: use new macro.
Capitalize.
> When glibc is built with --enable-static-nss, the warning that
[...]
This kind of text usually goes before the ChangeLog fragment in a posting.
> +/* Warning for NSS functions, which don't require dlopen if glibc
> + was built with --enable-static-nss. */
> +#ifdef DO_STATIC_NSS
> +#define nss_interface_function(name)
It's "# define" inside #ifdef.
> +#else
> +#define nss_interface_function(name) static_link_warning(name)
> +#endif
Likewise, and space before paren on the rhs.
You may commit the change with those fixes and reports of successful builds
both with and without --enable-static-nss.
Thanks,
Roland