This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Use bash to run nptl/tst-tls6.sh


The test nptl/tst-tls6.sh uses brace expansion so may not work with
all POSIX shells.  This patch marks it as a bash script and arranges
for it to be run with $(BASH).  (A more complicated patch to the
script, to avoid the use of brace expansion, was in the first version
of the cross-testing patch - I then removed it as not logically part
of cross-testing - and I can provide an updated version of that patch
to the script if preferred, but running the script with bash seems
simpler.)

Tested x86_64.

2012-10-25  Joseph Myers  <joseph@codesourcery.com>

	* Makefile ($(objpfx)tst-tls6.out): Use $(BASH) not $(SHELL) to
	run tst-tls6.sh.
	* tst-tls6.sh: Use /bin/bash not /bin/sh.

diff --git a/nptl/Makefile b/nptl/Makefile
index f84646e..c7bb61b 100644
--- a/nptl/Makefile
+++ b/nptl/Makefile
@@ -475,7 +475,7 @@ $(objpfx)tst-tls6.out: tst-tls6.sh $(objpfx)tst-tls5 \
 		       $(objpfx)tst-tls5moda.so $(objpfx)tst-tls5modb.so \
 		       $(objpfx)tst-tls5modc.so $(objpfx)tst-tls5modd.so \
 		       $(objpfx)tst-tls5mode.so $(objpfx)tst-tls5modf.so
-	$(SHELL) $< $(common-objpfx) $(elf-objpfx) \
+	$(BASH) $< $(common-objpfx) $(elf-objpfx) \
 		    $(rtld-installed-name) '$(test-wrapper-env)'
 endif
 
diff --git a/nptl/tst-tls6.sh b/nptl/tst-tls6.sh
index 6ef1232..27450c3 100755
--- a/nptl/tst-tls6.sh
+++ b/nptl/tst-tls6.sh
@@ -1,4 +1,4 @@
-#! /bin/sh
+#! /bin/bash
 # A tls test.
 # Copyright (C) 2003-2012 Free Software Foundation, Inc.
 # This file is part of the GNU C Library.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]