Re: [PATCH v2] change ifunc assembly test to a link test

[Mike Frysinger <vapier at gentoo dot org>]

On Tuesday 23 October 2012 14:20:02 Roland McGrath wrote:
> > 2012-10-22  Mike Frysinger  <vapier@gentoo.org>
> > 
> > 	* configure.in: Move READELF check to start of file.
> > 	(libc_cv_asm_gnu_indirect_function): Change to a link test.
> 
> Change the variable name and the message text to reflect what you're
> actually testing now.

so just change "asm" to "ld" ?  e.g. libc_cv_ld_gnu_indirect_function

> > +  # Do a link to see if the backend supports IFUNC relocs.
> > +  $READELF -r conftest 1>&AS_MESSAGE_LOG_FD
> > +  if ! LC_ALL=C $READELF -r conftest | grep -q 'no relocations'; then
> 
> We don't use newfangled features like the ! built-in and grep -q.
> Do:
> 
> LC_ALL=C $READELF -r conftest | grep 'no relocations' > /dev/null || {
>   ...
> }

hmm, current code is already using such features:
$ grep 'grep -q' configure.in 
if $CC -v -static-libgcc 2>&1 | grep -q 'unrecognized option.*static-libgcc';      
conftest.c -v 2>&1 >/dev/null | grep -q " -lunwind "; then
   && grep -q .note.GNU-stack conftest.s \
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.