This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] change ifunc assembly test to a link test

> 2012-10-22  Mike Frysinger  <vapier@gentoo.org>
> 
> 	* configure.in: Move READELF check to start of file.
> 	(libc_cv_asm_gnu_indirect_function): Change to a link test.

Change the variable name and the message text to reflect what you're
actually testing now.

> +  # Do a link to see if the backend supports IFUNC relocs.
> +  $READELF -r conftest 1>&AS_MESSAGE_LOG_FD
> +  if ! LC_ALL=C $READELF -r conftest | grep -q 'no relocations'; then

We don't use newfangled features like the ! built-in and grep -q.
Do:

LC_ALL=C $READELF -r conftest | grep 'no relocations' > /dev/null || {
  ...
}


Thanks,
Roland
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]