Re: [PATCH] disable var-tracking for math/test-tgmath2.c

["Carlos O'Donell" <carlos at systemhalted dot org>]

On Tue, Oct 16, 2012 at 4:48 PM, Markus Trippelsdorf
<markus@trippelsdorf.de> wrote:
> On 2012.10.16 at 11:57 -0700, Roland McGrath wrote:
>> Maybe we should split the code up into more functions or something.  If
>> there are things like that we can do that improve the compilation speed
>> without reducing our test coverage, there's no reason not to do them.  But
>> frankly I'd rather have slow compilation of a test case persist through a
>> few more GCC versions than do a cheesy hack like this.
>
> The test coverage is unchanged by the patch.
> And gcc disables var-tracking anyway as soon as the size limit is exceeded.
> (clang doesn't and takes over 15 minutes to compile the file with -g)

It does decrease test coverage, because now we
aren't compiling the test applications in the
same way that users would. What if -fno-var-tracking
was hiding a glibc implementation bug?

I would also rather have a slow compilation that
matches the user use cases than a fast compilation
that might potentially hide defects.

Can you provide a patch that adds acomment in the Makefile
that talks about the slow compilation, and references
the gcc and llvm upstream bugs that need to be fixed
in order to speed up the compilation?

Cheers,
Carlos.